Skip to content

Conversation

@nellh
Copy link
Contributor

@nellh nellh commented Aug 11, 2025

This adds a model for storing file checks for datasets. Initially this just records annex fsck output but additional fields can be added for other kinds of file based checks.

One mutation is added updateFileCheck which allows the worker to report annex fsck status on each commit.

For API authentication a token is generated using #3533's worker scope for a specific dataset.

@nellh nellh requested a review from thinknoack August 11, 2025 17:40
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 6.30631% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.31%. Comparing base (093bcc8) to head (4fe6994).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
packages/openneuro-server/src/models/fileCheck.ts 0.00% 36 Missing and 1 partial ⚠️
packages/openneuro-server/src/graphql/schema.ts 0.00% 35 Missing ⚠️
...penneuro-server/src/graphql/resolvers/fileCheck.ts 0.00% 16 Missing and 1 partial ⚠️
...rvices/datalad/datalad_service/common/openneuro.py 35.00% 13 Missing ⚠️
...openneuro-server/src/graphql/resolvers/mutation.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
- Coverage   48.44%   48.31%   -0.13%     
==========================================
  Files         596      598       +2     
  Lines       42232    42355     +123     
  Branches     1391     1393       +2     
==========================================
+ Hits        20459    20465       +6     
- Misses      21604    21719     +115     
- Partials      169      171       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@thinknoack thinknoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one question about schema.

@nellh nellh merged commit c74ebad into master Aug 11, 2025
13 of 15 checks passed
@nellh nellh deleted the feat/update-file-check-mutation branch August 11, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants